Greg Kroah-Hartman… urged fellow contributors to embrace those interested in contributing Rust code to improve the kernel.

"Adding another language really shouldn’t be a problem… embrace the people offering to join us

Thoughts on this?

  • FarceOfWill@infosec.pub
    link
    fedilink
    English
    arrow-up
    25
    arrow-down
    2
    ·
    edit-2
    15 hours ago

    Despite my drive-by shitposts in the rest of this thread I want to make a serious point here.

    There’s a large part of software engineering that thinks languages are chosen based on the problem, as a tool for a job.

    They aren’t. They’re chosen based on the team, on how well the team knows and can use the tool. On how many people can be hired with the knowledge of the tool to work immediately.

    Sometimes, even if the team knows C well, there can be a problem so different it’s worth using another tool. say python for some testing scripts on a C project.

    But rust and C are too similar for this to apply. If you want rust to be used for the kernel you have to push for it to be more well known and used, so more Devs come into teams already knowing it well. Anyone agreeing to work on a team using rust is making a career decision that will be stay on their CV forever and you need them to feel good about this, that it will give them more opportunity in future.

    It’ll take 20+ years because that’s how long legacy code is often maintained for and we already have 20+ years of future legacy code for C teams to deal with. We’re all making more future legacy C code than future legacy rust code too.

    I’m trapped in C++ so I’m doomed but good luck C and Rust coders.

    • barsoap@lemm.ee
      link
      fedilink
      English
      arrow-up
      2
      ·
      9 hours ago

      Unsafe Rust may be similar to C, though even though there’s wibbles like the borrow checker still running, you still get more guarantees about the code than with C. Safe Rust can, on occasion, look more like Haskell than C.

      Are they both systems languages? Yes of course otherwise we wouldn’t be talking about using them in the kernel. Makes no sense to extend the possible comparison candidates to include Prolog, arbitrarily making look C and Rust more similar by introducing a far-off comparison point.

      • sugar_in_your_tea@sh.itjust.works
        link
        fedilink
        English
        arrow-up
        3
        ·
        5 hours ago

        Unsafe Rust may be similar to C

        It’s really not. I’d much rather use C than unsafe Rust…

        The best part about Rust is you can isolate your memory safety problems to the unsafe bits, whereas with C, you have to constantly deal with it.

  • LedgeDrop@lemm.ee
    link
    fedilink
    English
    arrow-up
    12
    arrow-down
    8
    ·
    15 hours ago

    In my mind, introducing Rust would only make sense if:

    1. There was a serious lack of current kernel developers (which I don’t think there is)
    2. New hardware and tech was evolving at a rate that the Linux Kernel could not keep up (again, I don’t think this is am issue)
    3. The end goal is to migrate the entire Kernel to Rust.

    Regarding point 3, having both C and Rust really only makes sense as a transition phase (measured in years) - as it would require kernel developers to be savvy in both C and Rust, or would force developers to stay within whatever domains were implemented in C or Rust.

    • Thinker@lemmy.world
      link
      fedilink
      English
      arrow-up
      10
      ·
      10 hours ago
      1. There was a serious lack of current kernel developers (which I don’t think there is)

      Maybe not at the moment, but my understanding is that the pool of qualified C programmers is shrinking rapidly, because the old guard is all ageing out and there simply are not enough intermediate developers coding in C at the level that Kernel development requires.

      Having a larger (and growing) pool of upcoming developers interested in systems programming and software excellence is one of the explicit stated reasons that Linus et al. considered Rust in the first place.

    • WalnutLum@lemmy.ml
      link
      fedilink
      English
      arrow-up
      14
      ·
      13 hours ago

      it would require kernel developers to be savvy in both C and Rust

      From my experience knowing how both C and rust works makes you a better developer in both languages.

      • LedgeDrop@lemm.ee
        link
        fedilink
        English
        arrow-up
        5
        arrow-down
        2
        ·
        12 hours ago

        Oh absolutely, but you could argue the same for learning lisp or mastering any functional programming language (list comprehensions, etc). It will improve your design patterns when you go back to an object oriented language with some elements of functional programming.

        • WalnutLum@lemmy.ml
          link
          fedilink
          English
          arrow-up
          1
          ·
          2 hours ago

          Again from my experience, knowing lisp (yay guix and emacs) definitely helps me write more elegant code in every language.

          I also have to explain almost every single thing I write in code review.

        • barsoap@lemm.ee
          link
          fedilink
          English
          arrow-up
          6
          ·
          9 hours ago

          Nah it’s a different axis. Rust doesn’t have a GC, you do need to think about memory, it’s just that the compiler generally enforces things for you. You learn to think like borrowck thinks because you don’t want to get yelled at. Going back to C then you suddenly mistrust a lot of code a lot more, and rightly so.

    • gedhrel@lemmy.world
      link
      fedilink
      English
      arrow-up
      9
      ·
      15 hours ago

      What’s in your mind does not coincide with the professional experience of Greg KH. You shoyld read what he had to say on the subject.

      • LedgeDrop@lemm.ee
        link
        fedilink
        English
        arrow-up
        1
        ·
        12 hours ago

        What?!? Actually, read the article? What is this, Reddit? /s

        Seriously, though - let me spin the question around: what, in your mind, overlaps with what Greg said?

        (plus, OP was just interested in people opinions - not whether they align/contradict with Greg, Linus, etc)

          • sugar_in_your_tea@sh.itjust.works
            link
            fedilink
            English
            arrow-up
            3
            ·
            5 hours ago

            For the lazy, I liked these parts:

            Rust isn’t a “silver bullet” that will solve all of our problems, but it sure will help in a huge number of places, so for new stuff going forward, why wouldn’t we want that?

            Yes, I understand our overworked maintainer problem (being one of these people myself), but here we have people actually doing the work!

            The whole thing is great.

          • gedhrel@lemmy.world
            link
            fedilink
            English
            arrow-up
            3
            ·
            11 hours ago

            To add something to this: linux has avoided internal SPIs for a long time. It’s often lauded as one of the reasons it hasn’t ossified.

            However, some subsystems have a huge amount of complexity and hidden constraint in how you correctly use them. Some of that may be inherent, but more of it will be accidental.

            Wrapping type-erased shims around this that attempt to capture (some of) those semantics shines a light onto the problem. The effort raises good technical questions around whether the C layer can be improved. Where maintainers have approached that with an open mind, the results are positive for both C and Rust consumers. Difficult interfaces are a source of bugs; it’s always worth asking whether that difficulty is inherent or accidental.

  • gravitas_deficiency@sh.itjust.works
    link
    fedilink
    English
    arrow-up
    74
    arrow-down
    2
    ·
    1 day ago

    I’ve gotten into the most hilariously circular debates with rust opponents on this point. Their arguments tend to come down to “just don’t write bad code”.

    The team is only as strong as the weakest link. The release is only as good as the least talented dev. Tools that raise the entire foundation are objectively good. Even better are tools that outright prohibit you from even writing entire categories of bugs. Rust is that tool.

    And yeah I know it’s not perfect, and it shouldn’t be treated as a panacea. But its advantages should be lauded, not derided because some contributors like to maintain the walled garden of knowledge as if it were a secret spellbook.

    • sugar_in_your_tea@sh.itjust.works
      link
      fedilink
      English
      arrow-up
      28
      arrow-down
      1
      ·
      edit-2
      1 day ago

      I don’t know about you, but I prefer provably correct code over “just trust me bro.”

      There’s an analogy I like here. A manager at a trucking company was hiring a new driver, and he asked each of them how close they could get to the edge on a mountain pass. The first said, “I can get within a wheel’s width.” The second said, “I can drive on the edge, with part of the tire hanging off.” And the third said, “I stay away from the edge.” The third applicant got the job, because why take the risk?

      That’s how I feel about C/C++. Why use them if Rust can do the job? You get a lot more safety features without sacrificing performance, what’s not to like?

        • sugar_in_your_tea@sh.itjust.works
          link
          fedilink
          English
          arrow-up
          4
          arrow-down
          1
          ·
          10 hours ago

          Okay? I know a half dozen languages well, and am pretty productive with a half dozen more. If you’re an experienced software engineer, picking up a new language should be easy. If a language is useful for a given task, I use it. If another language offers benefits I want, I learn it.

          It’s like any other profession, why limit yourself to one tool? If a new tool comes out and does the job better, use it.

          I love C and it’s my first choice for low level work like microcontrollers. However, it’s not great for larger projects, especially ones with significant security concerns, since subtle vulnerabilities in different areas could be combined to create an attack. Rust provides a lot of protection against common attacks without a performance cost, so it’s a good choice.

          • riodoro1@lemmy.world
            link
            fedilink
            English
            arrow-up
            2
            ·
            9 hours ago

            I think they know C a little better than just to be „productive” with it. And also a lot of those people are not so young anymore to learn a new language well enough to feel comfortable with writing a kernel in.

            • sugar_in_your_tea@sh.itjust.works
              link
              fedilink
              English
              arrow-up
              4
              ·
              8 hours ago

              As do I. I could jump into a modern C codebase and feel comfortable. I’ve worked on microcontrollers, built servers (UDP, TCP, and HTTP), and worked with cross thread communication. If I know what I want to build, I can achieve it with C. Maybe not as quickly as someone who works with it every day (it has been a while), but within a month I’d be back in shape.

              I feel the same about Python, Go, JavaScript (both on server and FE, either React or straight DOM manipulation), and Rust (I use it for personal projects extensively). When I write C++, it usually turns out like C with vectors and smart pointers, so I’ll add that in as well. Except for Rust, I’ve used all of these in a professional capacity (and I did technically do a couple POCs in Rust). I could list a bunch of other languages I’m less confident in, but could also use professionally if needed without needing to study first.

              I’m not suggesting they go out and do the same, I’m merely suggesting that when an option comes along that solves some serious problems they run into every day, maybe they should try it. Most of the languages I mentioned are useless for kernel development, so it makes no sense for them to bother with them. However, Rust is really interesting because it comes with some very compelling guarantees, and you don’t get many guarantees when it comes to low level development.

              If I told a kernel dev that I had a tool that can identify most if not all memory safety/soundness issues in their C code, they wouldn’t hesitate to try it out. But if I ask them to try out Rust (same guarantees), they’ll refuse. Why? Hubris and stubbornness.

      • WalnutLum@lemmy.ml
        link
        fedilink
        English
        arrow-up
        4
        arrow-down
        1
        ·
        13 hours ago

        Did somebody say “provably correct”?

        Haskell has entered the chat

      • gravitas_deficiency@sh.itjust.works
        link
        fedilink
        English
        arrow-up
        13
        ·
        22 hours ago

        That’s kind the entirety of my point: if Rust is a tool that can make expressing algorithms safer and less prone to error - and it can, in a logically provable sense - then what the fuck ground do you have to push back on?

        • enumerator4829@sh.itjust.works
          link
          fedilink
          English
          arrow-up
          2
          arrow-down
          3
          ·
          9 hours ago

          I’m still kind of on the fence about Rust in the kernel. Linux isn’t some random hobby project, there are serious people working for serious companies in the project. Rust has a clear value proposition w.r.t. it’s qualities as a language, but I don’t think it’s as clear on a system level.

          Say I’m working for a large company as a dev, maintaining a subsystem (let’s say a driver). Letting other people (filthy casual hobbyists) mess around with their filthy type safety will eventually spill into my subsystem and cause extra work. I don’t want the extra work, I just want to have my driver working and then go home. And even if I’m okay with the extra work, my boss won’t be. Even the risk of extra costs down the line will be enough for some to shut it down completely.

          There are boring people working for huge corporations with huge stakes in the Linux kernel. I don’t think they see that much value in Rust at the moment, and I think the Rust crowd might need to hire some MBAs if they want to expand their presence in the kernel.

          • gravitas_deficiency@sh.itjust.works
            link
            fedilink
            English
            arrow-up
            3
            ·
            9 hours ago

            Oh, so that’s actually a thing I specifically do not care about.

            I tolerate MBA types at my job because they’re part of an equation that yields a paycheck to me. I don’t believe those MBA types should be in the discussion at this level at all.

            In fact, that sort of insistence on implementation details from product and manager types who can’t ever fucking commit to addressing tech debt issues until the system is falling apart is one of the primary frustrations I have in my career.

            • enumerator4829@sh.itjust.works
              link
              fedilink
              English
              arrow-up
              1
              arrow-down
              2
              ·
              8 hours ago

              I don’t believe those MBA types should be in the discussion at this level at all.

              That’s the thing. They are in the discussion. It doesn’t matter what we think about it. If touching Rust risks yielding lower profits this quarter, it’s an automatic ”fuck off you filthy hobbyists”. Even having the discussion costs money.

              Rust in the kernel isn’t about technology, it’s about economics and risk management. I’d like to see the discussion move on from ”C bad unsafe rust gud typesaf” to a level where the suggested benefits of Rust are made clear to the people holding the bags of money, preferably presenting some actual monetary benefits. (Oh, and to make things worse, there are thousands of different stakeholders, with different interests, many of which are in conflict. Good luck!)

              So yeah, I get that you don’t care about it. But you probably should.

    • Lost_My_Mind@lemmy.world
      link
      fedilink
      English
      arrow-up
      14
      arrow-down
      2
      ·
      1 day ago

      Their arguments tend to come down to “just don’t write bad code”.

      Oooooh, that’s a good stratagy! Write that down! Write that down!

  • mariusafa@lemmy.sdf.org
    link
    fedilink
    English
    arrow-up
    5
    arrow-down
    6
    ·
    9 hours ago

    Rust lacks a language standard. Without that is meaningless programming something with pieces that may change in the future (like what happened with Python) is not a good idea in my opinion.

    • scratchee@feddit.uk
      link
      fedilink
      English
      arrow-up
      13
      ·
      edit-2
      8 hours ago

      Technically, the kernel doesn’t compile with pure standard C, they require strict aliasing to be disabled, so that alone doesn’t seem to be strictly required.

      Not saying that standards aren’t useful, but they’re not some dividing line separating the true languages from the joke languages, they’re just a useful document that earns a language a few “good language” points, but those points can be earned other ways too.

      For example, rust has pretty good versioning, so even if the devs did totally wreck the language in the next version, it’d maintain compatibility with older code just fine, which sort of invalidates your point, unless you’re worried that the devs turn malicious, but the language is open source, so I imagine that would get it forked pretty quickly.

  • Dr. Moose@lemmy.world
    link
    fedilink
    English
    arrow-up
    4
    arrow-down
    17
    ·
    22 hours ago

    I feel like better tooling is a safer bet. I know people hate on AI here but tooling that can detect flaws in C memory management would be basically as good as Rust itself.

    • sugar_in_your_tea@sh.itjust.works
      link
      fedilink
      English
      arrow-up
      2
      ·
      5 hours ago

      True. We should have both better tooling and better languages. Someone posted this thread with Greg KH, which has this gem:

      The majority of bugs (quantity, not quality/severity) we have are due to the stupid little corner cases in C that are totally gone in Rust. Things like simple overwrites of memory (not that rust can catch all of these by far), error path cleanups, forgetting to check error values, and use-after-free mistakes. That’s why I’m wanting to see Rust get into the kernel, these types of issues just go away, allowing developers and maintainers more time to focus on the REAL bugs that happen (i.e. logic issues, race conditions, etc.)

      I’m all for moving our C codebase toward making these types of problems impossible to hit, the work that Kees and Gustavo and others are doing here is wonderful and totally needed, we have 30 million lines of C code that isn’t going anywhere any year soon. That’s a worthy effort and is not going to stop and should not stop no matter what.

      But for new code / drivers, writing them in rust where these types of bugs just can’t happen (or happen much much less) is a win for all of us, why wouldn’t we do this?

      In short, let’s do both.

  • Zachariah@lemmy.world
    link
    fedilink
    English
    arrow-up
    13
    arrow-down
    31
    ·
    edit-2
    1 day ago

    Just fork it, do a complete rewrite in Rust, and call it “Runix”

    More OS options is better for everyone.

    • RonnieB@lemmy.world
      link
      fedilink
      English
      arrow-up
      68
      arrow-down
      1
      ·
      1 day ago

      The one thing stopping large scale adoption of linux is definitely the lack of options.

    • JeremyHuntQW12@lemmy.world
      link
      fedilink
      English
      arrow-up
      4
      arrow-down
      12
      ·
      22 hours ago

      Theres heaps of stuff that is under-developed or mssing, but they prefer to rewrite working code in Rust, because ideology.

      We are witnessing the death of Linux here, no less, replacing a working kernal with an still undefined language that everyone will have forgotten in 5 years.

  • Buffalox@lemmy.world
    link
    fedilink
    English
    arrow-up
    11
    arrow-down
    28
    ·
    edit-2
    15 hours ago

    That does NOT sound like a good idea.

    We’ve turned our development model into a well-oiled engineering marvel,

    Exactly, and I’m pretty sure one of the reasons is that it’s remained on C, and NOT switched to C++, as has been often suggested.
    The second they make it a mixed code base, that’s the same second quality will deteriorate. Mixed code base is a recipe for disaster.

    Edit:

    Torvalds eventually responded by defending the Linux kernel development process and scolding Martin for grandstanding on social media about the issue. Martin later quit as a Linux maintainer and resigned from the Asahi Linux project.

    Seems like Linus isn’t onboard with this.

    But I guess all the downvoters know better?

    opening for a mixed code base is a recipe for disaster.

    Greg Kroah-Hartman:

    Yes, mixed language codebases are rough, and hard to maintain, but we are kernel developers, dammit.

    That’s special pleading, that lacks basis in reality. Still he admits it’s rough to mix codebases.

    I’m not claiming Rust wouldn’t be brilliant in some situations, but the detraction of a mixed codebase is worse than the benefit.

    • sugar_in_your_tea@sh.itjust.works
      link
      fedilink
      English
      arrow-up
      3
      ·
      5 hours ago

      It’s not like Linux compiles down to one binary or anything, most of it is linked together over a pre-determined API. Anything that can satisfy that API (and ABI) can drop in. There are some “magic” bindings, but they still conform to that API.

      Read the rest of Greg KH’s thread, here’s the last half of that paragraph:

      Adding another language really shouldn’t be a problem, we’ve handled much worse things in the past and we shouldn’t give up now on wanting to ensure that our project succeeds for the next 20+ years. We’ve got to keep pushing forward when confronted with new good ideas, and embrace the people offering to join us in actually doing the work to help make sure that we all succeed together.

      And earlier:

      Rust also gives us the ability to define our in-kernel apis in ways that make them almost impossible to get wrong when using them. We have way too many difficult/tricky apis that require way too much maintainer review just to “ensure that you got this right” that is a combination of both how our apis have evolved over the years (how many different ways can you use a ‘struct cdev’ in a safe way?) and how C doesn’t allow us to express apis in a way that makes them easier/safer to use. Forcing us maintainers of these apis to rethink them is a GOOD thing, as it is causing us to clean them up for EVERYONE, C users included already, making Linux better overall.

      Those are solid arguments. As long as the APIs are well designed and documented, a mixed codebase is fine, and you get most of the benefits of Rust where it’s used.

    • farcaster@lemmy.world
      link
      fedilink
      English
      arrow-up
      44
      arrow-down
      2
      ·
      1 day ago

      Moving from C to C++ would also not solve any real problem. C++ of course adds OOP which I think can be nice (not everyone agrees with this!) but it also adds an insane amount of language complexity and instability. Mentally reasoning about C code is hard, reasoning about C++ code is nearly impossible.

      Rust however brings a novel solution to classes of problems like ownership and mutability with the borrow checker. It’s now accepted to be a great tool for writing high performance code while preventing a substantial amount of common, but often subtle, bugs from slipping through. It’s not arbitrarily the first non-C code to be accepted in the kernel. And it’s used in other operating systems like Android and Windows already.

      • sugar_in_your_tea@sh.itjust.works
        link
        fedilink
        English
        arrow-up
        17
        ·
        edit-2
        10 hours ago

        In general, for me, Rust > C > C++.

        I’ve heard people say that C is like a loaded and cocked revolver, and if you’re not careful, you could blow your foot off, whereas C++ is like a loaded and cocked sawed-off shotgun, and if you’re not careful, you could blow your leg off.

          • gedhrel@lemmy.world
            link
            fedilink
            English
            arrow-up
            3
            ·
            11 hours ago

            Whilst it’s gotten a lot better in the -17 and -20 iterations, the fact that there was recently a doorstop book published solely on the subject of C++ initialisation semantics is pretty telling.

            I really like what Herb Sutter’s doing around cppfront; I still wouldn’t use C++ unless I absolutely had to.

      • brucethemoose@lemmy.world
        link
        fedilink
        English
        arrow-up
        14
        arrow-down
        1
        ·
        1 day ago

        Mostly this ^.

        There’s just not really demand for C++ in the kernel; that’s not the case with Rust.

      • mesamune@lemmy.world
        link
        fedilink
        English
        arrow-up
        13
        arrow-down
        1
        ·
        edit-2
        1 day ago

        I think rust would also bring in more developers. So more changes would eventually make its way into the kernel.

    • darklamer@lemmy.dbzer0.com
      link
      fedilink
      English
      arrow-up
      9
      ·
      23 hours ago

      The second they make it a mixed code base, that’s the same second quality will deteriorate.

      I envy your confidence!

      • Buffalox@lemmy.world
        link
        fedilink
        English
        arrow-up
        1
        ·
        15 hours ago

        Maybe I’m wrong, but as I read the article, Linus isn’t convinced this is a good idea either.
        I’m not saying things can never change, but opening for a mixed code base is a recipe for disaster.

        • gedhrel@lemmy.world
          link
          fedilink
          English
          arrow-up
          2
          ·
          15 hours ago

          You’re wrong, but it’s possible the article gave you that impression. Read the mailing-list thread.

          It’s particularly worth reading Ted T’so’s contribution, which (considering his rude behaviour at the recent con led to a previous round of this nonsense) seems much more positive.